html-modules-toolkit icon indicating copy to clipboard operation
html-modules-toolkit copied to clipboard

Select the parent of the script containing `import.meta.document`

Open aaronmars opened this issue 6 years ago • 5 comments
trafficstars

See https://github.com/PolymerLabs/html-modules-toolkit/issues/14. Aligns the transform for import.meta.document with the explainer/proposal at https://github.com/w3c/webcomponents/blob/gh-pages/proposals/html-modules-explainer.md

aaronmars avatar May 07 '19 14:05 aaronmars

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar May 07 '19 14:05 googlebot

I signed it!

aaronmars avatar May 07 '19 15:05 aaronmars

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar May 07 '19 15:05 googlebot

Thanks for looking into this 🙌 left a note, LMKWYT!

cdata avatar May 07 '19 18:05 cdata

Oh yeah. Wow. I completely mis-read the code there. Makes sense now! I'll get that fixed up.

aaronmars avatar May 09 '19 17:05 aaronmars