Tony Brix comments

Results 612 comments of


                                            Tony Brix

bind response - password expiring overrides force password change

If you have an issue with the types in @types/ldapjs you can create an issue on the [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped) repo.

Question: How to return error if user is not found?

I would check if searchEntry has been called in end and if it hasn't there are no entries.

In Client.bind() password gets logged at trace level

looks like this had a PR (#491) but it has since been abandoned. @saostad if you want to create another PR that would be much appreciated. 😁👍

change ldapjs.org dns record

We could just use `ldapjs.github.io` by moving the gh-pages branch to the repo `ldapjs/ldapjs.github.io`

change ldapjs.org dns record

I created the repo and set up https://ldapjs.github.io/ I think it would be better if we could work something out with Joyent to keep the domain, but if not we...

client.bind() should not pass an error to the callback function before having tried to connect to all server urls

Should it emit all of the errors if all servers fail? or just the last error?

client.bind() should not pass an error to the callback function before having tried to connect to all server urls

I kind of think it should emit every error as it does now. Then the user can decide how they want to handle the error.

Multithreaded Server?

I think [worker threads](https://nodejs.org/dist/latest-v14.x/docs/api/worker_threads.html) were supposed to fix most of the issues in node cluster.

client listener events documentations

It might also be worth it to consolidate some of these events to make them more intuitive

> InvalidAsn1Error: Expected 0x2: got 0x63 That usually means something received the wrong type. The types at https://ldap.com/ldapv3-wire-protocol-reference-asn1-ber/ seem to indicate it was looking for an `Integer` but received a...