Tony Brix

Results 612 comments of Tony Brix
trafficstars

this seems like an issue with your server. Are there any errors on your server when `sizeLimit` is sent? It could also be that `JSON.stringify` is failing in your `doSearch`...

according to https://github.com/ldapjs/node-ldapjs/issues/313#issuecomment-151724190 it could be an issue where your server is limiting the number of results because you aren't binding to a user.

Can you add a test for this change?

Those were passing before this change so they don't really show the need for this change.

That's what I was talking about in https://github.com/ldapjs/node-ldapjs/pull/574#issuecomment-541458835 . I don't know of any other packages that uses event emitters and callbacks. I'm thinking the easiest way to solve it...

If someone wants to create a PR with the fix we can look at it. Make sure to add a test as well.

If @panva is willing to add it, I think that would be the better option as well.

Thanks for responding @panva. :+1: Well, I guess creating a package with the `@ldapjs` namespace it is.

@kushwahav PRs are always welcome 😁👍

types are provided by [`@types/ldapjs`](https://www.npmjs.com/package/@types/ldapjs). We cannot confirm that they are accurate since we did not write them. Follow the directions in the error message: ``` Try `npm i --save-dev...