Róbert Papp

Results 838 comments of Róbert Papp
trafficstars

I just spend 15 mins trying to figure out what's wrong as well. Because you're in a `dependencies` block Groovy is being clever. We need to prefix `properties` with `project.`...

@dawidhyzy it works if you use `project.properties....` or `project.hasProperty`

Rebased onto latest `master` including Gradle update and integration tests. Needed https://github.com/JakeWharton/butterknife/pull/1170/commits/f6563e5bd26b5debf2ed383e583e2486bfea72b0 to be able to test.

Feels like I should rebase again :)

Ref: this is a regression of https://github.com/JakeWharton/butterknife/issues/1074 with a newer version: > butterknife-runtime-10.1.0.aar\...\lint.jar: Lint found an issue registry (butterknife.lint.LintRegistry) which is older than the current API level; these checks may...

@JakeWharton it looks like butterknife is way past that fix mention in SO, it was fixed in 3.0 alpha, and current active is 3.5.14, latest is 3.5.15. @Aggelos88 is it...

Theoretically if you run hilt it generates dagger code, right? So it should be possible to get it working with reflect.

There's a cycle test in upstream as well: https://github.com/JakeWharton/dagger-reflect/blob/dec8f8f75256fe70d2fbd86d671b6723de562337/integration-tests/upstream/build.gradle#L21-L23 But I guess this will never execute because https://github.com/JakeWharton/dagger-reflect/issues/4#issuecomment-646408154

What do you think about testing cycles and checking that the instances actually end up the same when scoped?

Do you have an extra abstract method / interface method that's not `@Binds` nor `@Multibinds` somewhere in a `@Module`? (based on the if-else-if structure this is the only way to...