dagger-reflect icon indicating copy to clipboard operation
dagger-reflect copied to clipboard

Published 20 hours ago • verified publisher icon JakeWharton

Creates cycle indirection scenarios for tests

Open gfreivasc opened this issue 5 years ago • 4 comments

Creates IndirectionCycle with regular provided dependencies,BindsIndirectionCycle for bound dependencies indirection, and MultibindProviderMapIndirectionCycle for the scenario pinpointed in issue #175 and resolved by #198.

gfreivasc avatar Aug 20 '20 14:08 gfreivasc

There's a cycle test in upstream as well: https://github.com/JakeWharton/dagger-reflect/blob/dec8f8f75256fe70d2fbd86d671b6723de562337/integration-tests/upstream/build.gradle#L21-L23 But I guess this will never execute because https://github.com/JakeWharton/dagger-reflect/issues/4#issuecomment-646408154

TWiStErRob avatar Aug 20 '20 17:08 TWiStErRob

What do you think about testing cycles and checking that the instances actually end up the same when scoped?

TWiStErRob avatar Aug 20 '20 17:08 TWiStErRob

Quickly looking at it, it seems that perhaps some of these tests are okay to run. I'll take a look, since upstream currently covers two of the three tests.

gfreivasc avatar Aug 20 '20 17:08 gfreivasc

I think the test scenario and tests suffice, right?

gfreivasc avatar Aug 20 '20 19:08 gfreivasc