Róbert Papp

Results 835 comments of Róbert Papp
trafficstars

@JakeWharton Played around a bit, but couldn't make it work. 1. In the current state applying the proguard rules, DaggerAppComponent is not kept: ```gradle // integration-tests/android/build.gradle buildTypes { debug {...

Uuuuh, @mochadwi I have no memory of doing this investigation :D, but here are my thoughts: 3. works: I said "everything works", from me that usually means app works as...

Based on the kdoc you linked to me it looks like you still must put `@Retention()` so only `annotation class X` doesn't seem to have RUNTIME retention. However your claim...

Looks like ProGuard is trying to find `dagger-android` classes to know what can be processed and how. If you don't have that dependency, add it. `runtimeOnly` should be enough, that...

0c4e911 is unlikely to produce anything other than unchecked, rawtypes and deprecation, which all would be visible in IDEA anyway as warnings, so quick to notice and usually very easy...

Rebased and fixed all of the current warnings. `gradlew clean check` runs without warnings, except: This unfixable warning from AGP: ``` > Task :integration-tests:android:processCodegenDebugResources Changing the value for a property...

Double-force-pushed to resolve the conflict (deleted file in another PR) and see the code review changes: https://github.com/JakeWharton/dagger-reflect/compare/a524045a02c38ec895911264f989ef7d7ea9e3fa..1efaa5293e48123358781e6067cebf83574c3e91

> I've merged and cherry-picked about 7 or 8 of the commits in this PR. ok, thanks; will rebase and continue to discuss the rest

If only I knew, I guess https://github.com/JakeWharton/dagger-reflect/search?q=notImplemented&unscoped_q=notImplemented is a good starting point (sadly it doesn't show all occurrences, only 1 for each file). I wouldn't put it in the README...

@PaulWoitaschek added limitations.