Róbert Papp

Results 835 comments of Róbert Papp
trafficstars

@Nolapete JSON is not a data structure, it's a language to represent one.

`jcenter()`, why not just accept the "de facto" repo for Android so users can use it more easily? 5 minutes suffering per release for you saves hours for your users.

@JakeWharton here's a repro: 1. https://github.com/TWiStErRob/repros/tree/master/retrofit/proguard-removed-return-type 2. Run the app (debug variant) Expected: Activity starts and reads the header: ``` I/okhttp.OkHttpClient:

@JakeWharton while I'd love to see that for its tech, I'm not sure that would solve the problem. - If someone finds this issue, they'll know what to do (keep)....

That said, adjusting the error message might be useful, because retrace is not helpful here if you have many retrofit interfaces. (click to expand for what I tried) ### `retrace`-ing...

Hmm, that's a good point, thanks for clarifying. I just checked the rx1 and rx3 adapters in this repo, and they have keep rules. Just to understad more, is your...

Yep, duplicate of #2238; #2241 fixes the issue. Confirmed with repro on 3.8.0 and no repro on 3.9.0 (https://github.com/mockito/mockito/commit/f5b9975e9305f596e208d840ea90c483193aadd3 included on 3.8.14 onwards)

I found a workaround: https://github.com/TWiStErRob/repros/tree/master/parceler/fail-on-warning, but it's quite elaborate.

Something like [`dagger.moduleBindingValidation`](https://github.com/google/dagger/issues/900#issuecomment-466222685) would be nice.

Hmm, that actually gave me an idea for another workaround: ```kotlin kapt { javacOptions { option("-Werror") } } ``` since these warnings are coming from Javac running the annotation processor...