Fabian Zills

Results 90 comments of Fabian Zills
trafficstars

> Basically, would you consider adding your ZnJSON converters to jsonpickle? They'd need to be adapted to work with jsonpickle's API, but if they work and you're willing/able to contribute...

I added a very simple base64 encoder (looking a bit at your code) for numpy and ran a quick benchmark of ZnJSON vs jsonpickle, which you can have a look...

~~This seems to be fixed in 0.13.0+e571ba9~~

> cons: can only run on the main branch, because PRs can be opened by anyone (see [self-hosted runner security](https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#self-hosted-runner-security)) Would it be an option to require approval for CI...

The ZnDraw package (https://github.com/zincware/ZnDraw) uses three.js, flask and websockets for communication. It does not rely on pythreejs and therefore has access to all three.js features. It relies on ASE (see...

> I took a look at the source code of ZnDraw. As I understand it, we can at the very least use the js side. I have updated the main...

From my understanding from https://wiki.fysik.dtu.dk/ase/_modules/ase/cell.html#Cell the conversion to numpy just does: ```py def __array__(self, dtype=float): if dtype != float: raise ValueError('Cannot convert cell to array of type {}' .format(dtype)) return...

Example of how this could look like, writing the entire graph config files at the end and not subsequently after each Node. ```python def node_to_dicts(node) -> tuple[dict, dict, dict]: """Create...