Make CI/CD infrastructure more sustainable

[jngrad]

trafficstars

Background

We have several CI jobs that require an infrastructure that is not easily available in GitHub Actions runners:

• GPU-equipped runners
• AMD-equipped runners (for portability tests)
• Mac Mini runners (for portability tests)
• large persistent storage for artifacts (2 GB per pipeline, retention for 3 months)
• large persistent shared cache (more than 4 GB)

This is currently achieved via webhooks, with a firewall allow list for GitHub IP addresses. However, our GitLab instance relies on custom, fragile PHP code to handle these webhooks. We need to find a more sustainable solution that is actively maintained.

Tasks

Communication between services

Find a suitable third-party app to handle communication between GitHub and GitLab.

Criteria:

• the app must be actively maintained
• must work both on the main branch and on pull requests
  • storing login credentials as secret environment variables is not acceptable, since they can be exfiltrated in base64
• should preferably be written in programming languages that ICP people are familiar with
  • this way someone can step in when the app fails and submit an actionable bug report upstream

One should look for suitable candidates in the Marketplace (query). Maybe github2lab_action? If it's impossible to establish a communication channel with the GitLab API in a safe way (i.e. without a way for a malicious actor to exfiltrate the credentials), look into webhook-based solutions, such as trigger-gitlab-ci-through-webhooks.

Registering new runners

We have two Mac Mini computers that need to become part of the CI fleet.

Two options are possible:

1. register them as self-hosted runners
   • pros: one can adapt the existing GitHub Action to use these runners instead of the cloud runner
   • cons: can only run on the main branch, because PRs can be opened by anyone (see self-hosted runner security)
2. register them as GitLab runners
   • pros: can be maintained like any other runner
   • cons: one has to find a suitable containerization method to avoid privilege escalation (maybe Cilicon?)

[PythonFZ]

cons: can only run on the main branch, because PRs can be opened by anyone (see self-hosted runner security)

Would it be an option to require approval for CI runs on forks?

[jngrad]

cons: can only run on the main branch, because PRs can be opened by anyone (see self-hosted runner security)

Would it be an option to require approval for CI runs on forks?

If you are willing to manually approve the CI run every time, then yes. We did something similar in the past, i.e. manually merging the main branch in the PR to trigger a CI pipeline that would confirm there were no hidden merge conflicts, and the core team quickly complained about the extra workload. We eventually installed the bors bot, and more recently the kodiak bot, to automatize that task.

[jngrad]

A proof of concept was developed by @pancan21 and @Dalouvid in GitHubActionAction/GitHubActionAction. See the readme file there to learn how the GitLab token is securely hidden from PR workflows, and what repository maintainers have to look for in PRs to maintain the secrecy of the GitLab token.

Next steps:

• write the GitLab API requests to synchronize the branches and trigger CI pipelines using the GitLab token
• look into GitHub token permissions with New tool to secure your GitHub Actions