Claus Due

Results 245 comments of Claus Due

Meta note, if you enable https://github.com/blog/2247-improving-collaboration-with-forks we can fix cosmetics for you ;)

getImgResource signature change is potentially breaking for other ViewHelpers using the trait - may not be exposed by unit tests either!

I'm not sure what the use case is for case sensitive sanitisation. The ViewHelper was written to write URL slugs/anchors which don't really benefit from case sensitivity. If you could...

Very true, this looks like a leftover from a time when the render children closure did not take the "content argument" into account. I would appreciate a pull request that...

Hi @kledo-34, Thanks for the request. Just a small note from here: implementation through Site configuration will break support for TYPO3 8.7 which still has to be supported, so an...

@cassini-mohsin Thanks for the patch - meanwhile, I merged another patch for the FAL relation fetching, but it has a tiny difference compared to your patch. The other one does...

@erredeco If possible, can you provide the full stack trace of the error? This would tell me which ViewHelper is used and I can look further into why it receives...

First part of the puzzle is here: https://github.com/FluidTYPO3/vhs/blob/development/Classes/ViewHelpers/Page/Resources/FalViewHelper.php#L66 VHS uses the default TSFE page repository instance to retrieve records. I'll check how `frontend_editing` manipulates the repository to achieve "show hidden...