Claus Due

Results 245 comments of Claus Due

Hi @faltrock-abone, I acknowledge this behaviour, and the fact that it is not correct - but it is almost certainly not going to be fixed, because: 1. This behaviour does...

Very nicely spotted, @moenadic! This seems like a valid solution and I've not been able to determine any negative effects from it; the original intention of the `+` in matching...

There was indeed a bug hidden under that missing test case - good call @mbrodala. I also wasn't completely pleased with how that converter code looked and how it would...

PS: our phpunit version is currently not able to handle mocking of interfaces with strict return types. We are working on upgrading that.

Half of this patch is made redundant by https://github.com/TYPO3/Fluid/pull/457 - will adjust.

Sounds like a perfect idea to me. The only objection I could come up with is it makes it ever so slightly harder to debug issues with typos in argument...

Full passthrough of also un-prefixed attributes is added in https://github.com/TYPO3/Fluid/pull/306/files#diff-a45384f75aed9dcc5b22b7a54cdbf66dR49 which is open as PR https://github.com/TYPO3/Fluid/pull/306. My thinking about this one is that when you write HTML and make a...

> how about a flag property to allow all attributes if someone wants to use it for new viewHelpers? This could make good sense. I'll work that into the patch...

> aside from removing the attributes form the documentation i can't think of a reason to allow this. What would an actual use-case be? I guess the top-three would be:...

> There i had a idea: Escaping behaviour should be dependent on the template filetype: > .html -> escape as planned > .js -> excape for use in js strings?...