Konstantin Myakshin

Results 150 comments of Konstantin Myakshin

hey @mejo- ! I will try to do next things: - fix/answer to your code review comments :construction: - fix conflicts after rebase :heavy_check_mark: - do manual testing :hourglass_flowing_sand: -...

So, here we go. I did rebase one more time and fixed few things. Here my manual test scenario: 1. switch to the current `main` branch 2. install module `./occ...

I've added video to prove that it works. Please review @juliushaertl @mejo- @max-nextcloud and run pipeline I will work on tests after initial review

rebased, fixed merge conflicts and disabled checkbox for users without edit permission. Please review

@mejo- all fine, I will do everything. No way to wait this changes before migration to Pinia? :pray:

@mejo- @juliushaertl mates, how can I understand what thee root cause of Behat tests failure? How can I run this tests locally to debug failure?

There was a bug in the test and code :smile: . Now all green except Cypres

BTW suggested workaround works fine for me. Add bootstrap file with next content ```php if (defined('BEHAT_BIN_PATH')) { (new PHPUnit\TextUI\Configuration\Builder())->build([]); } ``` maybe we can automatically prepend this using Behat internals

that's how [nuxt-sprite](https://github.com/nuxt-modules/svg-sprite) working

Here an blogpost with [PHP way](https://dev.to/javiereguiluz/reusing-svg-icons-for-faster-pages-62o) of this optimization