Konstantin Myakshin comments

Results 150 comments of


                                            Konstantin Myakshin

trafficstars

Bundle controller affected by DIExtraBundle

As we can see from `ControllerInjectorsWarmer` - all controller files processed.

DIExtraBundle required Annotation Class without using the class

@schmittjoh please fix this issue. Use case: 1. I'm installing SonataNotificationBundle 2. It has controller with FosRestBundle annotations 3. I haven't installed this bundle 4. Got an exception that annotation...

Suggest use is_a when it possible

> PS: it also possible to use instanceof here. no, because in this context `$resultBuilder` is FQCN, not an object.

[WIP] Refactoring of event listeners(closes #8, #89, #123, #297)

@stof what can you say about this PR in general? And I have some problem with Propel integration. Not sure this approach will work correctly

[WIP] Refactoring of event listeners(closes #8, #89, #123, #297)

@garak yes, will do it later after fiinish my other PRs. Also I should apply changes requested by @stof . This PR is much harder than other.

[WIP] Refactoring of event listeners(closes #8, #89, #123, #297)

branch restarted and rebased. I'm afraid that this PR breaks BC. But we can start working on 2.0 where BC-breaks are acceptable.

File can be removed physically from storage without db update

This bug requires investigation. We should create something like queue - **schedule** image removing before flush and actually remove it from storage on post flush. Haven't time/money for fixing it...

form field is broken when using flysytem and liip_imagine

@bruno-ds have you idea how it could be solved? Maybe open PR. Interesting issue, I think that many people can got it.

form field is broken when using flysytem and liip_imagine

Does your liipimagine data loaders configuration are in sync with vichuploader storage configuration? Have you tryed http://symfony.com/doc/master/bundles/LiipImagineBundle/data-loader/flysystem.html or http://symfony.com/doc/master/bundles/LiipImagineBundle/data-loader/stream.html ? Or https://symfony.com/doc/current/bundles/LiipImagineBundle/cache-resolver/aws_s3.html

[RFC] File namer for uniquely suffixing a file name if it is already taken

Namers hasn't know anything about storage. We need inject storage into namer for checking if file already exists. But this is not enough: we also need inject directory namer for...