collectives icon indicating copy to clipboard operation
collectives copied to clipboard

Save full width of page on server

Open Koc opened this issue 1 year ago • 5 comments

📝 Summary

Currently we are storing "Full width" inside local storage. This means, that this setting not shares between users and browsers. Would be nice to make this setting persistent on db level like in Confluence.

🖼️ Screenshots

https://github.com/user-attachments/assets/8b7372fe-807c-4a69-8db3-6d359a76ac0b

🚧 TODO

  • [ ] add tests after code review

🏁 Checklist

  • [x] Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • [x] Sign-off message is added to all commits
  • [ ] Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • [ ] Documentation (README or documentation) has been updated or is not required

Koc avatar Jul 25 '24 16:07 Koc

I've added video to prove that it works. Please review @juliushaertl @mejo- @max-nextcloud and run pipeline

I will work on tests after initial review

Koc avatar Jul 27 '24 23:07 Koc

rebased, fixed merge conflicts and disabled checkbox for users without edit permission. Please review

Koc avatar Aug 03 '24 11:08 Koc

@mejo- all fine, I will do everything. No way to wait this changes before migration to Pinia? :pray:

Koc avatar Aug 05 '24 15:08 Koc

@mejo- all fine, I will do everything. No way to wait this changes before migration to Pinia? 🙏

Sorry, pinia PR just got merged :grimacing:

mejo- avatar Aug 05 '24 21:08 mejo-

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

github-actions[bot] avatar Aug 09 '24 02:08 github-actions[bot]

@mejo- @juliushaertl mates, how can I understand what thee root cause of Behat tests failure? How can I run this tests locally to debug failure?

Koc avatar Aug 12 '24 22:08 Koc

@mejo- @juliushaertl mates, how can I understand what thee root cause of Behat tests failure? How can I run this tests locally to debug failure?

@Koc I'm pretty sure it's unrelated, but let's see. Given that your local Nextcloud instance is available under https://nextcloud.local, you can run the behat tests with make test-php-integration.

mejo- avatar Aug 13 '24 16:08 mejo-

There was a bug in the test and code :smile: . Now all green except Cypres

Koc avatar Aug 14 '24 22:08 Koc