Konstantin Myakshin

Results 150 comments of Konstantin Myakshin

I will try to do something with this at weekend

sorry for delay, haven't yet time to seat and consider how it should be realized :(

@imsamthomas Would be nice provide API for getting banners per slider name (or better rename name to code): ```php interface SliderRepositoryInterface { /** * Get banners list. * * @param...

@fabpot tests pass. Please review

update: - rebased on master - annotation properties are maked private - added default intention equal to `default` - updated docs - updated tests - created own exception. I doubt...

tests failures looks like unrelated to this PR

rebased on master again ping @fabpot questions that required to be resolved: 1a. should I add and register custom exception handler for converting `InvalidCsrfTokenException` to 403 response? Invalid csrf produces...

@fabpot can you make review and give advices to my previous questions, please? Would be nice finish this PR.

ping @fabpot Can you add some boilerplate template like https://github.com/Payum/Payum/blob/master/bin/subtree-split which help configure own splits for newcomers?

``` 14 Which function are mandatory to your command class ? | execute(InputInterface $input, OutputInterface $output), configure() | ✗ | | ``` Does `configure` is mandatory for 4.0? We can...