Julian Kemmerer
Julian Kemmerer
IIUC this does not pin a version of pycparser - and would, as coded now, have people doing git init recursive clone stuff and would pull the latest pycparser code...
It sounds like doing like this PR doing, and using git submodules to pull in pycparser at a certain commit point ~essentially having a copy of the repo inside pipelinec...
Yeah testing I want to do is basic - does it still seem to parse c code and not crash kinda tests Should have some time this week
Wow I just realized you got the pycparser 2.18 tagged commit version that should exactly match what I had copied into the repo - tests should go smoothly :+1:
IIUC New repo clone will need to be `git clone --recurse-submodules` And users pulling to update their repo need to one time update+init submodules ``` git pull git submodule update...
@AlexLao512 can you change the temp work around locations in code to use the absolute path to the repo? ``` from utilities import REPO_ABS_DIR # TODO: Temporarily import from submodule,...
Oh dope - I didnt know I could just commit and push to a repo owned by not my user (I guess forking my repo gives me access by default...
Something fucky is up Trying the branch I get a C parsing related ~'nodes in a dictionary arent as expected' internal pipelinec sanity check error (tried examples/blink.c) Weird... ```Parsing function:...
Hopefully I can get around to this in the next week or so :+1: , starting with the diff
OK I think I know whats going on. The version of the files I copied into my repo in ~2017/2018 some time was marked at version `2.18`. And that is...