idaes-pse

idaes-pse copied to clipboard

Sofc Keras Surrogates failing tests

2

Tests on sofc_keras_surrogate.py are failing due to an out-of-date Keras model that needs to be re-generated by someone who knows about the model. A deprecation warning indicating these failures has...

rundxdi

Report Numerical Issues does not issue a warning for a singular Jacobian

1

When troubleshooting issues revealed by #1395, I encountered this: ``` ==================================================================================== Model Statistics Jacobian Condition Number: 9.195E+14 ------------------------------------------------------------------------------------ 1 WARNINGS WARNING: 54 pairs of variables are parallel (to tolerance 1.0E-08)...

dallan-keylogic

Negative flow rates in BTX and demo flowsheet ill-conditioning

2

While working on #1395, I found that changes I made to the BTX scaling caused test failures for the [demo flowsheet](https://github.com/IDAES/idaes-pse/blob/main/idaes/models/flowsheets/tests/test_demo_flowsheet.py) on Linux while tests succeeded on Windows. Trying to...

dallan-keylogic

Update docs on use of miniforge

1

We need to update our documentation to suggest the use of miniforge rather than Anaconda or Miniconda

ksbeattie

Remove PySMO warnings in tests

1

PySMO warnings we want to remove. Related to #1363 Warnings from PySMO from (closed PR) #1403: ``` idaes/core/surrogate/pysmo/tests/test_kriging.py::TestKrigingModel::test__init__08[array] idaes/core/surrogate/pysmo/tests/test_kriging.py::TestKrigingModel::test__init__08[DataFrame] idaes/core/surrogate/pysmo/tests/test_kriging.py::TestKrigingModel::test__init__09[array] idaes/core/surrogate/pysmo/tests/test_kriging.py::TestKrigingModel::test_predict_output_01[array] idaes/core/surrogate/pysmo/tests/test_kriging.py::TestKrigingModel::test_predict_output[array] /home/runner/work/idaes-pse/idaes-pse/idaes/core/surrogate/pysmo/kriging.py:354: RuntimeWarning: invalid value encountered in log log_like...

dangunter

Fixes #1421 ## Summary/Motivation: They are annoying ## Changes proposed in this PR: - Change print() to log - Lower log level in tests - Cleanup: remove `pylint-disable` comments ###...

dangunter

Potential reshuffling for “WaterTAP UI” code Context: this UI lets you configure and run any flowsheet, including sweeps, if it is “wrapped” with the appropriate export of desired input/output values....

dangunter

Minor improvements to scaling API

1

## Fixes None ## Summary/Motivation: Based on initial demonstrations of the new scaling tools, a few minor improvements have been suggested. ## Changes proposed in this PR: - Change API...

andrewlee94

We should inspect the Sphinx documentation (and anywhere else where Conda is mentioned) and ensure that: - [ ] [Miniforge](https://github.com/conda-forge/miniforge?tab=readme-ov-file#miniforge), as opposed to other similar Conda installation solutions such as...

lbianchi-lbl

Fix nested flowsheet time domain construction

10

## Fixes ## Summary/Motivation: In the current implementation of FlowsheetBlock, nested flowsheets with a time domain can only inherit time from the parent flowsheet. ## Changes proposed in this PR:...

NishantGiridhar