idaes-pse
idaes-pse copied to clipboard
Negative flow rates in BTX and demo flowsheet ill-conditioning
While working on #1395, I found that changes I made to the BTX scaling caused test failures for the demo flowsheet on Linux while tests succeeded on Windows. Trying to dig into the problem I discovered two issues:
- The problem Jacobian had a condition number on the order of 10^15
- There were negative values for
flow_mol_phaseinmodel.fs.M01.inlet_2_state.
I dealt with the second issue by adding bounds for it (and other similar variables) in #1395, but that caused the initialization to fail. Because it was clear that something was fundamentally wrong with the flowsheet that scaling could not fix, I didn't want #1395 to be dragged even further off-topic and so xfailed two tests involving the demo flowsheet.
Somebody needs to go back and either fix the issues with the demo flowsheet or replace the BTX property package with some suitable variation of the modular properties.
There appears to be an issue where the heater in the flowsheet has very little to do, because the feed comes in at 377 K and the heater outlet is set to 380 K. However, lowering the feed temperature didn't fix the underlying singularity.