idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Sofc Keras Surrogates failing tests

Open rundxdi opened this issue 1 year ago • 2 comments
trafficstars

Tests on sofc_keras_surrogate.py are failing due to an out-of-date Keras model that needs to be re-generated by someone who knows about the model. A deprecation warning indicating these failures has been added.

rundxdi avatar Jun 13 '24 17:06 rundxdi

Discovered in #1401

ksbeattie avatar Jun 13 '24 18:06 ksbeattie

This will need to wait for #1401 to be merged before re-generating the model (and other keras related ones).

ksbeattie avatar Jun 20 '24 18:06 ksbeattie

This should be done independently of #1401 so that #1401 is not held up. A separate PR after #1401 is merged should be created once @AlexNoring recreates the model using the updated (post-#1401) supported version of Keras/Tensorflow.

lbianchi-lbl avatar Jul 25 '24 19:07 lbianchi-lbl

The SOFC flowsheets in the examples repository no longer use the keras surrogates. I'd suggest we simply remove the files.

AlexNoring avatar Aug 16 '24 15:08 AlexNoring

@bpaul4 will open a PR addressing this.

ksbeattie avatar Aug 22 '24 19:08 ksbeattie