idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Fix nested flowsheet time domain construction

Open NishantGiridhar opened this issue 1 year ago • 10 comments
trafficstars

Fixes

Summary/Motivation:

In the current implementation of FlowsheetBlock, nested flowsheets with a time domain can only inherit time from the parent flowsheet.

Changes proposed in this PR:

  • Moved code to create a new time domain into a private method.
  • Create a new time domain for a nested FlowsheetBlock if time_set is provided during construction.
  • Added tests.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

NishantGiridhar avatar Oct 05 '24 01:10 NishantGiridhar