Hector Zarco comments

Results 44 comments of


                                            Hector Zarco

code is a mess - depends on jquery - does not update properly on resize

This issue must be a joke, @soenkekluth how can you open an issue in a repo that is not yours without having contributed to it at all and saying that...

Custom progress indicator

Yeah I think we should stop adding more props and instead use the render children approach. That will make even possible to make the example from above (text under the...

props children

Thanks for the PR @EdDevs2503 ! Can you add a unit test to make sure we render the children when they are given? thanks!

props children

We should also add `children` prop to `CircleProps`

The entire app example is rerendered every frame of the animation

@jrmuizel thanks for reporting that. Can you please confirm that the app still re-rendering? did some profiling locally and couldn't reproduce

Chart displays oddly with progress greater than 100%

Hi @mikefrederick ! I never thought about this honestly, but your suggestion makes sense to me. Would you like to submit a PR with that change? I will more than...

Loading mode

Interesting! I think we can add it, in terms of api, will you just pass something like? ``` import Circle from 'react-circle' ```

video dimensions

I believe you will do that by: ``` {(video, state, actions) => ( {video} ) ```

[Feature Request] allow passing of custom ref to component

Hi @pr1ntr ! Is `React.forwardRef` what you will be interested on?

Cannot disable interceptors (+workaround)

Thanks a lot for the issue, it looks like there is a bug in the lib as you mentioned! The workaround works but it should not be necessary to do...