code is a mess - depends on jquery - does not update properly on resize

[soenkekluth]

better use mine: https://github.com/soenkekluth/sticky-state (demo is yours with my module) overflow:auto > position:sticky will be supported in a moment

[soenkekluth]

as you can see - i added support for polyfilled (fixed sticky) inside an overflow:auto container. https://rawgit.com/soenkekluth/sticky-state/master/examples/index.html

so the native feature becomes statefull and the polyfill supports different viewports. browser support : >= IE9 no dependencies! jank free with animationFrame

[soenkekluth]

and finally: polyfill behaves exactly like the native feature... https://rawgit.com/soenkekluth/sticky-state/master/examples/index.html utraperformant!

[soenkekluth]

there is also a react component now https://github.com/soenkekluth/react-sticky-state

[zachleat]

Looks great! I’d love some of these ideas in the fixed-sticky plugin. I made an issue for one above.

I don’t think we’ll support the overflow feature but can you be more specific about some of the other complaints re: performance and resize problems? We do have resize handlers in our plugin.

[zachleat]

Oh, and if you’re using our demo code you should at probably include some kind of attribution, yeah?

[soenkekluth]

@zachleat of course i will add attribution to the demo. when i was using fixed-sticky not long ago in a project the dimensions of the fixedsticky-dummy were not recalculated when the window resized for example. in your update method you recalculate several values like dimensions of the sticky element and the parent offsets and so on. in my module i cache these values and only recalculate them if really needed. then your not using animationFrame... and well... jquery is not really needed

[zzarcon]

This issue must be a joke, @soenkekluth how can you open an issue in a repo that is not yours without having contributed to it at all and saying that the code is a mess?

The first thing you point in the issue is better use mine, latter you wrote 3 more comments just talking about how utraperformant! its your repo and pointing to the React version of it, which is not related at all with this.

I mean im happy that you have created your own repository and you think it's better than this one, but you should learn how to respect code of other people and don't use it to SPAM them in other issues. This stuff doesn't help anyone, not the maintainers, not the users and not you.