zzak

@intrip I took a quick look, this one tab was open all day.. The approach seems good to me? But I think it's better to wait for someone like @rafaelfranca...

@elliottmason Are you able to try this PR in your app? It would be good to know if there are any regressions before this is merged.

I don't think anyone going to object to using CI to debug something like this, but you might run into permission issues like to approve a build, then just ping...

Just looking at this now. > Exited with status 255 (after intercepting the agent’s termination signal, sent because the job was canceled) (soft failed) 255 apparently means the agent was...

After looking into this issue, my conclusion is that [ReaperTest#test_idle_timeout_configuration](https://github.com/rails/rails/blob/c60d064fd5f1d60d9cb8a09626e2633f88ed0985/activerecord/test/cases/reaper_test.rb#L125-L150) is the culprit. Disabling this test, I can no longer reproduce the failure, but I'm not sure how to actually...

@aliismayilov Pinging folks on GitHub is usually not a very effective way to received feedback, I suggest you ask in [discord](https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#get-some-feedback) for a review.

Another "me too" on using [sinatra-flash](https://github.com/SFEley/sinatra-flash) as a drop-in replacement, works great!

@simi Thanks for the ping, have been busy with other stuff but I may pick this back up. This also seems like a really good bite-sized feature for an early...

I don't think that is being added by RDoc: https://github.com/ruby/rdoc/search?q=notranslate Please re-open if I'm wrong. :pray:

@nobu Ahh, I think I misunderstood this. They want to add `notranslate` attribute. 👍