zzak

Results 331 comments of zzak

@epergo No these are good concerns, and why I wanted to open this ticket before doing any work. I've been a bit removed from Sinatra for some time now, so...

I think there is some unresolved feedback here: https://github.com/rails/rails/pull/41004#pullrequestreview-990279074 Also this PR needs to be rebased and commits squashed when they are ready. Given the age though, we might want...

Is there anything to do on Rails end here? Or just wait for that PR to be merged and released?

👍 to dropping support of Rainbows if that is blocking us from adopting Rack 3, maybe we can split it out into a separate gem or something for people who...

For now we can use this link: https://join.slack.com/t/sinatrarb/shared_invite/zt-1mtmzka43-xw6JED8Hb3M9Ha~1VgZxjQ It "never expires" but Slack says it's only good for up to 400 people. I think we may want to consider an...

Moving to discord instead, I've got it all set up. Here's the link: https://discord.gg/ncjsfsNHh7

@dentarg I've given `@sinatra/team-sinatra` admin access to that repo. Since that gem is deprecated, should it be archived as read-only?

@carlosantoniodasilva Thanks for the ping, yeah I'm not sure but maybe we can do `unless defined?`? I have to fix the tests (and probably rebase) upstream too, but I think...

Should we also remove these from AV? ``` $ git grep bad_customer actionpack/test/fixtures/bad_customers/_bad_customer.html.erb:1: bad customer: actionview/test/fixtures/actionpack/bad_customers/_bad_customer.html.erb:1: bad customer: $ git ls-files | grep formatted_xml_erb actionpack/test/fixtures/test/formatted_xml_erb.builder actionpack/test/fixtures/test/formatted_xml_erb.html.erb actionpack/test/fixtures/test/formatted_xml_erb.xml.erb actionview/test/fixtures/actionpack/test/formatted_xml_erb.builder actionview/test/fixtures/actionpack/test/formatted_xml_erb.html.erb actionview/test/fixtures/actionpack/test/formatted_xml_erb.xml.erb...

@seanpdoyle FWIW, I took a little different approach in #47301 (I wasn't aware of your PR at the time). Now circling back to this one, this logic always confuses me...