Younan Zhang

Results 57 comments of Younan Zhang

Clangd triggers an assertion failure when handling utf16 strings

Stacktrace with assertion enabled: ```bash clangd: /repo/llvm-project/clang/include/clang/AST/Expr.h:1852: StringRef clang::StringLiteral::getString() const: Assertion `(isUnevaluated() || getCharByteWidth() == 1) && "This function is used in places that assume strings use char"' failed. PLEASE...

Install clangd before archiving

@HighCommander4 @hokein for the review. I have [run the CI](https://github.com/zyn0217/clangd/actions/runs/8589939558/job/23536801164) on my fork despite the failure at the release stage caused by my invalid GitHub credentials. I think that at...

Slow AST builds in code involving large array (e.g. 1000000 elements)

> I[23:08:12.423] (built by Brecht Sanders) clangd version 16.0.6 > I[23:08:12.424] argv[0]: D:\Software\Mingw-w64\bin\clangd.EXE I've noticed that this is not an official windows clangd release. Looking around the build source, I...

Slow AST builds in code involving large array (e.g. 1000000 elements)

> But the official clangd.exe is using MSVC headers, how can i configure it to use GCC headers from WinLibs? One typical way is to have clangd extract the include...

Slow AST builds in code involving large array (e.g. 1000000 elements)

> I edited my Compiler fragment but nothing changed. I might have overlooked something, but it seems that you're not running clangd with the --query-driver option. That being said, if...

Slow AST builds in code involving large array (e.g. 1000000 elements)

> I[10:07:53.215] --> reply:textDocument/documentSymbol(912) 2010 ms I[10:07:53.215] --> reply:textDocument/semanticTokens/full/delta(913) 1363 ms I[10:07:53.215] --> reply:textDocument/inlayHint(914) 1294 ms I[10:07:53.216] --> reply:textDocument/inlayHint(915) 1294 ms I[10:07:53.216] --> reply:textDocument/documentLink(916) 1039 ms This is, indeed, outrageously...

Slow AST builds in code involving large array (e.g. 1000000 elements)

So I can now reproduce the slowness. I've set up a windows dev with mingw-w64 gcc and clangd 17.0.2, and recovered the original code from the log above: ```cpp #include...

Slow AST builds in code involving large array (e.g. 1000000 elements)

The sluggish responsiveness on code completion sheerly disappears if I reduce the array size to a smaller number, like 10. ```cpp vector edges[100010]; ``` to ```cpp vector edges[10]; ``` And...

Slow AST builds in code involving large array (e.g. 1000000 elements)

Simplified code snippet: ```cpp struct S { int data; void *ptr; } s[1000000]; // Note the size here int main() { s[0].^ } ``` One can observe the responsiveness latency...

Slow AST builds in code involving large array (e.g. 1000000 elements)

> Perhaps it could be related to that? Maybe. I don't have an available nightly build for Windows at the time, so it's hard to tell if this has been...