Younan Zhang

Results 57 comments of Younan Zhang

[Clang] Add captures to the instantiation scope for noexcept specifiers

Thanks for the review.

[Clang] prevent setting default lexical access specifier for missing primary declarations

Thanks!

Poor allocator usage

Clangd uses clang as a library, and clang has not provided a mechanism for us to take over every memory allocation/deallocation. Therefore, it is impossible for us to make a...

[Clang] Assertion `Unqualified ? hasSameUnqualifiedType(X, Y) : hasSameType(X, Y)' failed.

@mizvekov Looking at https://github.com/llvm/llvm-project/blob/64779455b8f4875c7de690dd4c3e324dbbcb3029/clang/lib/Sema/SemaExprCXX.cpp#L7094-L7095 I think this should be `return Context.getCommonSugaredType(LTy, RTy, true)` because we cannot have qualifiers on `void`?

clangd crashes when deducing template arguments

This is caused by 50e5411e. I will look into it @mizvekov

No diagnostic for error in instantiated context

I’ve noticed that the strategy we now used for optimizing(simply ignore function bodies in header files when building preamble) not only affects diagnostic messages aforementioned, but also type deduction for...

Parameter pack empty when accessed in Header

I filed an issue upstream: https://github.com/llvm/llvm-project/issues/172464