Jiashun Zhu
Jiashun Zhu
Hi Martin, Thanks for the translation work. Since it's auto-translation, we need to check it manually and make sure there is no misunderstanding in English version. Could you please also...
@Martin-Lierschof Ah I see. Adding a notice at the beginning would be great.
@Martin-Lierschof Hi, I skimmed through the translation and found something confusing that auto-translation didn't catch. Could you take another look?
@guodongxiaren Sorry 之前漏掉这条了。Sync一下重新提一下? @wwbmmm 之前baidu内部有类似的需求吗
Bazel的编译挂了: ``` [1,115 / 1,457] 11 actions, 2 running Compiling src/brpc/esp_message.cpp; 1s linux-sandbox Compiling src/brpc/details/usercode_backup_pool.cpp; 0s linux-sandbox [Sched] Compiling src/brpc/uri.cpp; 10s [Sched] Compiling src/brpc/details/rtmp_utils.cpp; 9s [Sched] Compiling src/brpc/details/tcmalloc_extension.cpp; 8s [Sched]...
这个PR merge以后是否可以再开一个issue记录一下EventDispatcher有些函数名的implementation specific问题,比如目前EventDispatcher::AddEpollOut表明只针对epoll有效。
> 目前是源文件针对不同的平台有不同的实现,但是头文件是通用的。AddEpollOut在Linux上是epoll,mac上是kqueue。后面看看要不要改成更为通用的名字 https://github.com/apache/incubator-brpc/issues/1894
@hcoona Hi, Could you upload the newest version if anything has changed since last time?
Thanks. I will have a look later.
CI is fixed in the latest version. Could you merge master and submit again?