Junfan Zhang comments

Results 434 comments of


                                            Junfan Zhang

[#1401][part-1] The dashboard supports multiple Coordinator links.

Could you help review this? @xianjingfeng

[Improvement] Introduce HybridRpcServer to implement ServerInterface for GRPC_NETTY

cc @jerqi @leixm

[Improvement] Introduce HybridRpcServer to implement ServerInterface for GRPC_NETTY

Are interested on this? @rickyma I do a poc PR to fix, but I don't have much time to finish this. Can you pick up?

[#1401][part-1] The dashboard supports multiple Coordinator links.

> No progress for this? I think we need a more powerful dashboard. Do you have thought on this? feel free to discuss more here

[#1401][part-1] The dashboard supports multiple Coordinator links.

@xianjingfeng Could you help review this?

[FEATURE] Provider uber jar for cli/dashboard/coordinator/server module

WDYT? @yl09099 @xianjingfeng @jerqi

[FEATURE] Provider uber jar for cli/dashboard/coordinator/server module

> For cli, it is ok. But for other modules, using uber jar may make it more difficult to find problems and it may lead to many useless dependencies that...

[Bug] msg: Zstd only supports the same type of bytebuffer decompression

Do you know the managedBuffer is not direct buffer when getting memory by netty? @leixm

[Bug] msg: Zstd only supports the same type of bytebuffer decompression

> > Do you know the managedBuffer is not direct buffer when getting memory by netty? @leixm > > Does this happen when netty is turned on or off? RssShuffleDataIterator...

[Bug] msg: Zstd only supports the same type of bytebuffer decompression

I found sometimes the bytebuffer is not direct after coverting from netty direct bytebuf using `bytebuf.nioBuffer()`