apache
[#1401][part-1] The dashboard supports multiple Coordinator links.
What changes were proposed in this pull request?
After multiple coordinators are deployed, a dashboard is added to link multiple coordinators.
Why are the changes needed?
Fix: #1401
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No.
Codecov Report
Attention: Patch coverage is 16.00000% with 42 lines in your changes missing coverage. Please review.
Project coverage is 53.91%. Comparing base (
6f6d35a) to head (5806b8f). Report is 49 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1449 +/- ##
============================================
- Coverage 54.86% 53.91% -0.96%
- Complexity 2358 2947 +589
============================================
Files 368 440 +72
Lines 16379 23613 +7234
Branches 1504 2197 +693
============================================
+ Hits 8986 12730 +3744
- Misses 6862 10095 +3233
- Partials 531 788 +257
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can we also fix the following spelling issues in this PR?
My suggesion will be: ResigerTime -> RegistrationTime in files: dashboard/src/main/webapp/src/components/shufflecomponent/ActiveNodeListPage.vue dashboard/src/main/webapp/src/components/shufflecomponent/DecommissionednodeListPage.vue dashboard/src/main/webapp/src/components/shufflecomponent/DecommissioningNodeListPage.vue dashboard/src/main/webapp/src/components/shufflecomponent/LostNodeList.vue dashboard/src/main/webapp/src/components/shufflecomponent/UnhealthyNodeListPage.vue
@yl09099
Can we also fix the following spelling issues in this PR?
My suggesion will be: ResigerTime -> RegistrationTime in files: dashboard/src/main/webapp/src/components/shufflecomponent/ActiveNodeListPage.vue dashboard/src/main/webapp/src/components/shufflecomponent/DecommissionednodeListPage.vue dashboard/src/main/webapp/src/components/shufflecomponent/DecommissioningNodeListPage.vue dashboard/src/main/webapp/src/components/shufflecomponent/LostNodeList.vue dashboard/src/main/webapp/src/components/shufflecomponent/UnhealthyNodeListPage.vue
@yl09099
Have changed.
No progress for this? I think we need a more powerful dashboard.
Do you have thought on this? feel free to discuss more here
No progress for this? I think we need a more powerful dashboard.
Do you have thought on this? feel free to discuss more here
I believe the dashboard should be updated regularly, as it provides the most intuitive experience for users. And it facilitates the management and operation of the RSS cluster for dev and ops.
I think it could be improved by:
- https://github.com/apache/incubator-uniffle/issues/1401
- https://github.com/apache/incubator-uniffle/issues/1618
- https://github.com/apache/incubator-uniffle/issues/1622
- https://github.com/apache/incubator-uniffle/issues/1623
- https://github.com/apache/incubator-uniffle/issues/1471
- https://github.com/apache/incubator-uniffle/issues/1624
- ... and so on?
@zuston
Test Results
2 434 files +1 2 434 suites +1 5h 1m 41s :stopwatch: + 1m 23s 935 tests +1 934 :white_check_mark: +1 1 :zzz: ±0 0 :x: ±0 10 829 runs +1 10 815 :white_check_mark: +1 14 :zzz: ±0 0 :x: ±0
Results for commit af382be3. ± Comparison against base commit cc3f52b6.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is a flaky test. We can ignore this for now. I have already created an issue for this https://github.com/apache/incubator-uniffle/issues/1628.
It is ready for review? Can anyone review this? We wanna use this on production this month. @yl09099
