incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[Improvement] Introduce HybridRpcServer to implement ServerInterface for GRPC_NETTY

Open zuston opened this issue 2 years ago • 3 comments

Code of Conduct

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, the streamServer of netty and grpc server are created in the different places. From my prospective, we could introduce HybridRpcServer to implement ServerInterface for GRPC_NETTY.

In the HybridRpcServer, the grpc and netty should be started.

How should we improve?

No response

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

zuston avatar Dec 07 '23 07:12 zuston

cc @jerqi @leixm

zuston avatar Dec 07 '23 07:12 zuston

Are interested on this? @rickyma I do a poc PR to fix, but I don't have much time to finish this. Can you pick up?

zuston avatar Jan 19 '24 03:01 zuston

Are interested on this? @rickyma I do a poc PR to fix, but I don't have much time to finish this. Can you pick up?

Interested, but I've encountered a very serious #1472 issue, still working on it. Can you help me fix this issue first? It is a very serious bug. This results in our inability to use it on a large scale in production.

rickyma avatar Jan 19 '24 04:01 rickyma