Gabriel Nordeborn

Results 452 comments of Gabriel Nordeborn

This is still a thing I'd like us to have a look at eventually. It's about untagged variants sometimes producing excessive code. Example: ```rescript let v = JSON.Array([String("hello")]) let x...

This has been solved. Latest v12 beta now gives this nice output instead: ```javascript import * as Stdlib_Array from "./stdlib/Stdlib_Array.js"; let v = ["hello"]; function x(x$1) { if (Array.isArray(x$1)) {...

CI seems to fail still.

@Bushuo this will need backporting to v11 anyway so if you want you could do a PR on top of this that just backports this to v11 and try it...

> > @Bushuo this will need backporting to v11 anyway so if you want you could do a PR on top of this that just backports this to v11 and...

> @zth why do we need v11 support? Because it's likely a large portion of users will remain on v11 for a good while. Backporting this will mean that those...

@Bushuo great work! ⭐

For now, you'll have to define your own shims. But these things are all going into the compiler in v12 as `Core` is integrated, so we're going to make sure...

This is a good reminder that we should do a round of testing with gentype and see what the current state for v12 is.

Thanks for the report! Who's best to look at this, @mununki perhaps?