zonemaster-engine
zonemaster-engine copied to clipboard
The Zonemaster Engine - part of the Zonemaster project
The `Zonemaster::Engine::ASNLookup` module has two global variables `@db_sources` and `$db_style`. These get computed once based on profile properties, but they are never reset. These global values should either be reset...
The `$profile->set()` method raises exceptions for both illegal profile property values and API contract violations. In an application we want to handle these to cases differently. Errors resulting from illegal...
In CLI we present error messages in response to user errors. I believe it is our policy to internationalize these error messages. Whenever CLI users specify overrides to profile property...
Spelling
## Purpose Fixes misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling). ## Context The misspellings have been reported at https://github.com/jsoref/zonemaster-engine/actions/runs/9671897619#summary-26683311397 ## Changes ... ## How to test this PR The action will...
A test zone is delegated with two in-bailiwick name servers with glue in parent. The zone has the equivalent NS records, but there are no address records for the two...
In the documentation [/docs/Translation-translators.md](https://github.com/zonemaster/zonemaster-engine/blob/master/docs/Translation-translators.md) redirect to [zonemaster/docs/internal-documentation/maintenance/Instructions-for-translators.md](https://github.com/zonemaster/zonemaster/blob/develop/docs/internal-documentation/maintenance/Instructions-for-translators.md) that doesn't exist. It must link to [docs/internal/maintenance/Instructions-for-translators.md](https://github.com/zonemaster/zonemaster/blob/develop/docs/internal/maintenance/Instructions-for-translators.md) Furthermore the documentation in [docs/Translation.pod](https://github.com/zonemaster/zonemaster-engine/blob/master/docs/Translation.pod) already points to the correct documentation. we have two solutions:...
## Purpose This PR removes an obsolete document, `docs/Translation-translators.md`. ## Context Fixes #1358 ## How to test this PR N/A.
## Purpose Clarify that zonemaster doesn't actually know if the server didn't receive the request, didn't send a response, or if the response was lost somewhere along the way. ##...
https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2Fname+%3Fserver.*+does+not+respond%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl++NOT+path%3A%2F%5Et%5C%2F%2F&type=code https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Basic.pm#L252 see #1353 for `name server` vs `nameserver` https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L193 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L197 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L201 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L237 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L241 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Connectivity.pm#L245 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Zone.pm#L405 Unlike most messages where zonemaster-engine has received a response and is able to critique...
https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2F+name+%3Fserver+%5B%5E%3D%5D%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl+&type=code There are probably times where it makes sense to use `name server` instead of `nameserver`, however,... https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2F%5B%22+%5Dname+%3Fserver+%5B%7B%5D%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl+&type=code https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Translator.pm#L84 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Translator.pm#L88 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Delegation.pm#L278 https://github.com/zonemaster/zonemaster-engine/blob/17688f7995e16dd9f5a4bec2a1437fc7804b31f0/lib/Zonemaster/Engine/Test/Nameserver.pm#L353