zonemaster-engine icon indicating copy to clipboard operation
zonemaster-engine copied to clipboard

Spelling

Open jsoref opened this issue 1 year ago • 4 comments

Purpose

Fixes misspellings identified by the check-spelling action.

Context

The misspellings have been reported at https://github.com/jsoref/zonemaster-engine/actions/runs/9671897619#summary-26683311397

Changes

...

How to test this PR

The action will report that the changes in this PR would make it happy: https://github.com/jsoref/zonemaster-engine/actions/runs/9671897732#summary-26683311682

jsoref avatar Jun 26 '24 01:06 jsoref

Do you want everything sent to develop, or should I just drop the commits that are problematic?

jsoref avatar Jun 26 '24 16:06 jsoref

Do you want everything sent to develop, or should I just drop the commits that are problematic?

The domain name change in the t file will make CI fail since then it will not match the recorded data, and re-recording will fail since the names will not match the implemented zones.

qr/^.* can not be undef/ is a matching expression and that will also fail if changed, as far as I can see.

I'll turn CI on.

matsduf avatar Jun 26 '24 18:06 matsduf

ok, I think I've dropped the changes that are likely to cause problems for CI. We can revisit them later.

jsoref avatar Jun 26 '24 18:06 jsoref

Please create the PR against the develop branch. If you click "edit" in the top you can change or I can do it.

matsduf avatar Jun 26 '24 19:06 matsduf

Release testing v2024.2: no issues found.

tgreenx avatar Dec 04 '24 17:12 tgreenx