Kat Marchán

Results 343 comments of Kat Marchán

@saboya the cache miss isn't what's causing the removal: it's a bug in the way npm itself recognizes and handles git dependencies.

Note: Tarball fetches do this already, which I'm actually kinda fine with -- most installs once package-lock.json is in place will only touch tarballs. As long as we can repeat...

Hm. It would take a bit of work to get this to work in the browser, and there's a lot you wouldn't be able to do, ever. Off the top...

I added some commentary since you mentioned you hadn't played with Promises before. Hopefully it helps :)

Oh and also thank you! This is looking great so far 🙆

Hey! Sorry, I missed your last update! This is looking great so far. The last thing I'd like to ask is whether you'd be willing/able to write a test for...

I'm pretty concerned about invalid/incomplete data making it into the cache. I bet this is streams being assholes again -- it might be worth making it so `make-fetch-happen` verifies `Content-Length`...

whoa, cool. This is a really cool and thorough PR, great job! So, how does this perform compared to registry or git packages? 🤔

Thank you! That's super useful to see. It's nice that it's not much worse than git. I'm definitely pretty surprised that it's still slower than a regular registry dependency when...

Nice! This is good sleuthing. This seems focused enough, too, that it might be a good starter issue, since it sounds like the primary fix is to make sure perms...