Zhian N. Kamvar

Results 211 comments of Zhian N. Kamvar

Hello @avallecam! Thank you for submitting a PR. Indeed this looks like a nice addition, though I will point out that it imports a lot of the tidyverse, which will...

Hi Nick, This particular legend is [a bit of a pain to work with](https://twitter.com/vsbuffalo/status/986494086319190016). At the moment, I'm not quite sure exactly HOW I would go about addressing the issue,...

The circles are usually underneath a border that's on a separate layer. SVGs are arranged in layers that tend to be grouped together. Have you attempted to ungroup the layers?...

Hi Nick, Thanks for responding with your results. My only other suggestion—until I can figure out how to resolve the issue on poppr's end—is to either: 1. take the size...

> When I scale the smaller circle up to the larger circle, the line width scales linear along with the radius of the circle. Makes sense, but I didn't think...

> On poppr side, I'm sure you thought of this, but would it work to construct the plot as a grid? If the MSN, population legend, and size legend were...

Thanks for the suggestion. I also think this would be a good thing to implement, however, my capacity for adding new functionality to poppr is a bit limited at the...

Would you be willing to submit a PR for this?

Thank you. For the record, with the advent of {styler}, ugly code is not much of a problem. For [contributions](https://github.com/grunwaldlab/poppr/blob/main/CONTRIBUTING.md), I require that they are formally tested.

For context, you are referring to the `pairwise_amova` function [as demonstrated here](https://github.com/zkamvar/Sudden_Oak_Death_in_Oregon_Forests/blob/master/Diversity_stats.Rmd#pairwise-amova-between-regions). It was part of the [PramCurry](https://github.com/zkamvar/Sudden_Oak_Death_in_Oregon_Forests/blob/master/PramCurry) package. Adding this in should be trivial. I will close this issue...