poppr icon indicating copy to clipboard operation
poppr copied to clipboard

Fix inefficient implementation of boot.bruvo

Open StaffanBetner opened this issue 3 years ago • 3 comments

Please place an "x" in all the boxes that apply

  • [x] I have the most recent version of poppr and R
  • [ ] I have found a bug
  • [x] I want to request a new feature

I have found that boot.bruvo is very inefficiently implemented. It would be a better approach to store the distance matrices per locus, and sample them with replacement, and then calculate trees, instead of recalculating the distance matrices for every iteration.


StaffanBetner avatar Aug 06 '20 21:08 StaffanBetner

Would you be willing to submit a PR for this?

zkamvar avatar Aug 07 '20 00:08 zkamvar

I only have some very ugly code that remedies this problem, but I will at least look into it. I suspect there are other speed improvments as well that can be done.

StaffanBetner avatar Aug 07 '20 16:08 StaffanBetner

Thank you. For the record, with the advent of {styler}, ugly code is not much of a problem. For contributions, I require that they are formally tested.

zkamvar avatar Aug 07 '20 17:08 zkamvar