Min Zhu
Min Zhu
context: [doc](https://docs.google.com/document/d/1g8HJCstkEEZZc73gFlQO8uPGs07SkWKkr7NG-Yg4bvM/edit?tab=t.0#heading=h.9t58aw3up7to)
[refreshAccessToke()](https://github.com/googleapis/google-auth-library-java/blob/89201558db913d9a71b3acccbab8eb0045ada6de/oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java#L496) posts request to OAuth2 token server (see [code](https://github.com/googleapis/google-auth-library-java/blob/89201558db913d9a71b3acccbab8eb0045ada6de/oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java#L507)). This code path is not exercised for TPC flow via getRequestMetadata(), but it is an public method and is possible to...
There are some pre-existing logs in this repo. We should migrate them to the debug logging with slf4j introduced in https://github.com/googleapis/google-auth-library-java/pull/1586 Some extra considerations: for DefaultCredentialsProvider fine/debug level logs, perhaps...
context: https://github.com/googleapis/google-auth-library-java/pull/1586#discussion_r1960466711 both metric and logging can benefit from this piece of information passing down. A minor refactor should achieve this.
similar incentives here: https://github.com/googleapis/sdk-platform-java/issues/1611#issue-1657837566 We should consider modernize our testing infra so we can benefit from new junit 5 features. In addition, JUnit 5 has an extension pack which allows...
This line in javadoc specifies ImpersonatedCredential can only be SA or User Credentials in this `create()` method, but it is not enforced. https://github.com/googleapis/google-auth-library-java/blob/a8d466f3951686ddf0f6a7ae429cab505b337c54/oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java#L120 For context: https://github.com/googleapis/google-auth-library-java/pull/1566#discussion_r1882521720
see this comment for context: https://github.com/googleapis/google-auth-library-java/pull/1528#discussion_r1801591146 builders are not created with generic types across this repo e.g. https://github.com/googleapis/google-auth-library-java/blob/f154edb3d8503d29f0020b6904dfa40e034ded93/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java#L486 This means to allow customer code to use a fluent builder API...
PiperOrigin-RevId: 765335193 currently blocked. see b/421467603
Came across this failure, seems flaky. full [log]([-devrel%2Fclient-libraries%2Fjava%2Fgoogle-cloud-java%2Fpresubmit%2Fintegration;config=default/log](https://btx.cloud.google.com/invocations/57e8a8cf-4970-4c4c-8cae-366cca2963e5/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fgoogle-cloud-java%2Fpresubmit%2Fintegration;config=default/log)) ``` 14:11:07:524 [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 3.670 s
ITSystemTest(sponge_log).detectFacesTest ITSystemTest(sponge_log).detectFacesGcsTest Some recent occurrences: https://fusion2.corp.google.com/invocations/11240a9c-7c58-41c1-a884-342dab92d857/targets/github%2Fgoogle-cloud-java%2Fjava-vision%2Fgoogle-cloud-vision%2Ftarget%2Ffailsafe-reports;config=default/tests https://fusion2.corp.google.com/invocations/9fa4718f-ba17-4bb8-9e19-da0c14872dc8/targets/github%2Fgoogle-cloud-java%2Fjava-vision%2Fgoogle-cloud-vision%2Ftarget%2Ffailsafe-reports;config=default/tests https://fusion2.corp.google.com/invocations/33bf3600-9795-47fe-8697-b08c6504321b/targets/github%2Fgoogle-cloud-java%2Fjava-vision%2Fgoogle-cloud-vision%2Ftarget%2Ffailsafe-reports;config=default/tests