google-auth-library-java icon indicating copy to clipboard operation
google-auth-library-java copied to clipboard

evaluate refactor builder patterns so that setters do not need to be override in child classes.

Open zhumin8 opened this issue 1 year ago • 0 comments

see this comment for context: https://github.com/googleapis/google-auth-library-java/pull/1528#discussion_r1801591146

builders are not created with generic types across this repo e.g. https://github.com/googleapis/google-auth-library-java/blob/f154edb3d8503d29f0020b6904dfa40e034ded93/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java#L486

This means to allow customer code to use a fluent builder API without casting, setters in parent classes need to be overriden in child classes, even without adding specific logics.

Note that adding generics to existing classes may also produce warning regarding raw use of generic types.

zhumin8 avatar Oct 17 '24 15:10 zhumin8