Lipeng Zhu

Results 65 comments of Lipeng Zhu

@wey-gu, sorry for the later response, we just reproduce the performance increase in master by enabling the AutoFDO. And the best result is found in FindShortestPath scenario, it can increase...

I can draft a document to describe the details to enable the AutoFDO for Nebula.

Hi @wey-gu , > is it possible that certain other scenarios could suffer from performance regression on this optimization? Maybe, but I rarely saw this situation, some scenarios didn't benefit...

> 1. On lower spec machines with less cores, say 2 or 4, will we see the similar improvements? The core numbers will not affect the perf gain, you can...

> io-uring comes with busy polling outside of the Valkey (io/main) threads. Does this CPU usage include that or just the CPU cycles accumulated by the Valkey threads? Actually, I...

> I think this is really good stuff. Performance is one of the areas we should prioritize IMO. Thanks @zuiderkwast, the question is how can we push this patch forward?

> As far as I know, IO_Uring is a high efficient IO engine. Do you have any plan to optimize Valkey's other modules by using io_uring technology? For example, ae...

@PingXie Thanks for your comments :) > @lipzhu, looking at your results above, the amount of the read calls jumps out too. > > ![image](https://private-user-images.githubusercontent.com/11568491/326147131-26b883de-fac2-4574-91ae-9611c7638f53.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQyNjc2NDMsIm5iZiI6MTcxNDI2NzM0MywicGF0aCI6Ii8xMTU2ODQ5MS8zMjYxNDcxMzEtMjZiODgzZGUtZmFjMi00NTc0LTkxYWUtOTYxMWM3NjM4ZjUzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDI4VDAxMjIyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0OTFiNzkwNTg2NmZkZDhlZGZiZjhjYTk4YzA3Njk0MTc5MDQ2NjllNjgwYTI5NDBjYmRmZWQzYzYxMzZjMjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hSeIMez40__FtdUisB8PpdNFXhz4D_hlhOllv9ySRpc) The counter data is based...

> Thanks @lipzhu! > > I am generally aligned with the high level idea (and good to know that you don't use polling). > > I do have some high...

If use already have redis-* binaries installed in local, the new created link will overwrite the binary, is it expected?