valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Create "redis" symlinks for the binaries in `make install`

Open zuiderkwast opened this issue 1 year ago • 4 comments

The binaries redis-server, redis-cli, etc. have already been renamed to valkey-*.

For compatibility, we want to create symlinks with the old names (redis-cli, etc.) to these in make install. These are located at the same place as the installed binarues, e.g. under /usr/local/bin/ or similar.

zuiderkwast avatar Apr 02 '24 15:04 zuiderkwast

If use already have redis-* binaries installed in local, the new created link will overwrite the binary, is it expected?

zhulipeng avatar Apr 03 '24 09:04 zhulipeng

Maybe we could do it by checking if there existredis-server and redis-cli and they are symlinks?

If they are symlinks, then we can create redis-* symlinks in make install and remove them in make uninstatll. We do not do anything if they are not symlinks.

vitahlin avatar Apr 03 '24 09:04 vitahlin

If you install one version of Redis on top of another version of Redis, you overwrite the binaries, right?

I don't think we shall skip creating the symlinks, because then users may have an old version of Redis which they didn't expect. We can have a makefile variable to disable creating the symlinks instead. Of course we need to mention this very clearly in the release notes.

zuiderkwast avatar Apr 03 '24 10:04 zuiderkwast

Thanks I will finish it

vitahlin avatar Apr 03 '24 15:04 vitahlin