zhou-run

Does the failed test make sense, or in other words, should the neighbor not be deleted when transitioning from UP to DOWN state? https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO5U18ARM8-2673 https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO8U18AMD64-2673 https://ci1.netdef.org/browse/FRR-PULLREQ3-ASAN7-2673 https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO1DEB10AMD64-2673

> > Does the failed test make sense, or in other words, should the neighbor not be deleted when transitioning from UP to DOWN state? https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO5U18ARM8-2673 https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO8U18AMD64-2673 https://ci1.netdef.org/browse/FRR-PULLREQ3-ASAN7-2673 https://ci1.netdef.org/browse/FRR-PULLREQ3-TOPO1DEB10AMD64-2673 >...

> > Does 'remove the context when the neighbor is removed from the configuration' refer to the command 'clear isis neighbor [WORD]'? > > No. I'm referring to CLI `no...

> Squash to a single commit all 3 commits. Should I create a new Pull Request to merge the commits? Because I can't find this Pull Request in my repository,...

> Squash to a single commit all 3 commits. Done.

> > > No. I'm referring to CLI `no isis router WORD` at the interface level which delete the IS-IS configuration on a given interface. > > Does this mean...

> > I tried the scenario of a P2P link. If the link goes DOWN without deleting the neighbor table entry, the new neighbor cannot be established because the old...

> what requested change are we waiting on here? I don't know either. @ton31337

> Can you show the backtrace? > > In my opinion the problem is in `isis_circuit_up()` when we create a list we don't specify `circuit->u.bc.adjdb[0]->del = isis_delete_adj;`. The issue lies...

> > The issue lies in isis_circuit_down(), not isis_circuit_up(). > > Yes, but the list needs to have a deletion hook when it's created. So it might be an issue...