zhou-run

> Let's clean up the commit message. `Please enter the commit ....` should not be there. Done.

> The signed off line does not match the name and email address above. I would expect that they should be matching. Done.

> Could you add a topotest to verify this patch/behavior? I currently have no plans to add topotest because this is a bug fix, not a new feature. In addition,...

> > I currently have no plans to add topotest because this is a bug fix, not a new feature. > > So? How do we ensure we don't hit...

> @zhou-run -> The FRR community expects the originator to write the topotest. Do you have a plan for when this will happen? I am currently writing and testing the...

My topotest passes on Debian 12 amd64, Debian 12 arm8, and Ubuntu 22.04 amd64, but it consistently fails on Debian 12 i386 due to P2P link neighbors not being able...

> `E Failed: New core[s] found: /tmp/topotests/isis_topo1.test_isis_topo1/r5/isisd_core-sig_11-pid_20721.dmp` Yes, this time the core issue is "E Failed: New core[s] found: /tmp/topotests/isis_topo1.test_isis_topo1/r3/isisd_core-sig_11-pid_18016.dmp". Check the logs related to the following operation. ``` r3#...

> Please use a short and direct title for the PR, as it is stand, from reading the title only, I can't tell what you are trying to do. IS...

I previously submitted this PR in #16056, and it passed the basic tests. However, it was reverted in #16160 because the basic tests failed when merging into other branches. Upon...

> can you explain why removing the check for these networks is the correct fix The routes I removed are all IPv4 local direct routes. ISIS should calculate these networks...