patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

Patternflyelements.com should link to version 1 documentation for pfe elements

Open zeroedin opened this issue 3 years ago • 4 comments

Currently, patternflyelements.com documentation is version 2 of PFE in pre-release. We need to add a link to version 1.X.X documentation for those maintaining current elements in production.

zeroedin avatar Mar 21 '22 15:03 zeroedin

I had a few thoughts on how to accomplish this

I think the above is more than enough to maintain a list of versions like v1 and v2 and eventually v3. I'd like it better if we could deploy by tag, and hey look here's a github action that does just that

https://stackoverflow.com/questions/61775854/how-to-use-github-actions-to-deploy-on-tag-to-netlify

more docs on that action it's pretty simple, just a single http call with curl, so if we need to extend it we can

if we pulled that off we could have:

  1. a dropdown which lists versions by repo tag (v1, v2, etc)
  2. a long lived permalink for which deploys to the major versions for each push to a semver-formatted tag (e.g. the v1 deploy would update when pushing to tag v1.12.4)
  3. a netlify.toml file which gets (manually?) updated every time we want to add a version
  4. and we can calculate the 11ty data for versions by reading the netlify.toml and using addGlobalData, no need to maintain a separate 11ty json file for that.

bennypowers avatar Mar 22 '22 12:03 bennypowers

This sounds like a much more maintainable idea to me. I like it.

zeroedin avatar Mar 23 '22 13:03 zeroedin

@zeroedin you still want this one?

bennypowers avatar Jun 26 '22 12:06 bennypowers

@zeroedin you still want this one?

Sure, I can take a stab at it.

zeroedin avatar Jun 28 '22 13:06 zeroedin

last good 1.12 docs: https://61f9ac3d5f4a9200081bb953--patternfly-elements.netlify.app/

bennypowers avatar Sep 28 '22 16:09 bennypowers