Kevin Smith
Kevin Smith
Resolves ## Submitter Checklist: - [ ] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my...
Resolves https://github.com/brave/brave-browser/issues/16619 ### Implementation Notes - Usage of `chrome.braveRewards` has been removed from the Rewards page. The message handler will now handle displaying of grant captchas in the Rewards panel...
Manual uplift of https://github.com/brave/brave-core/pull/14148 Fixes https://github.com/brave/brave-browser/issues/10433 Pre-approval checklist: - [ ] You have tested your change on Nightly. - [x] This contains text which needs to be translated. - [x]...
Resolves ## Submitter Checklist: - [ ] I confirm that no security/privacy review [is needed](https://github.com/brave/brave-browser/wiki/Security-reviews), or that I have [requested](https://github.com/brave/security/issues/new/choose) one - [ ] There is a [ticket](https://github.com/brave/brave-browser/issues) for my...
Currently, Rewards profile setup is spread out among several different methods on `RewardsService`, such as `EnableRewards` and `SetAdsEnabled`. For Rewards 2.5 we will need to have one simple API for...
Resolves https://github.com/brave/brave-browser/issues/25792 For easier reviewing, this change is split into 2 commits: the first removes all references to the Rewards extension and the second simply removes the Rewards extension folder....
A cancellation token design where the cancel token is explicitly passed into the async operation via a parameter can lead to parameter list pollution. For C#, this is perhaps mitigated...
Currently, I have `cancel.promise` exposing a promise for when cancellation is requested. There are some issues with this: - Race conditions caused by the time lag between cancellation being requested...
Cancel tokens seem to work really well for complex scenarios, but for really simple use cases, the API is awkward for the user. It takes too many lines of code...
This would be useful for bypassing block-scope translation when just running ES6 code directly on node/iojs.