brave-core icon indicating copy to clipboard operation
brave-core copied to clipboard

Add bubble for enabling cookie consent blocking (uplift to 1.43.x)

Open zenparsing opened this issue 2 years ago • 1 comments

Manual uplift of https://github.com/brave/brave-core/pull/14148 Fixes https://github.com/brave/brave-browser/issues/10433

Pre-approval checklist:

  • [ ] You have tested your change on Nightly.
  • [x] This contains text which needs to be translated.
    • [x] There are more than 7 days before the release.
    • [ ] I've notified folks in #l10n on Slack that translations are needed.
  • [x] The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • [ ] You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes is landed on.

zenparsing avatar Aug 12 '22 12:08 zenparsing

A Storybook has been deployed to preview UI for the latest push

brave-builds avatar Aug 12 '22 13:08 brave-builds

Closing as per the discussion with @rebron in the b-b meeting. We'll leave this in 1.44.x and enable it on Nightly via Griffin so we can start getting some bake time/feedback from 1.44.x. @zenparsing will create the Griffin issue to enable it 100% on Nightly.

kjozwiak avatar Aug 16 '22 18:08 kjozwiak