Ziad Beyens

Results 91 comments of Ziad Beyens

Makes a lot of sense. `renderStaticMarkup` was used as the quickest DRY solution, I'm open to any other alternatives. Otherwise I'm sure @dylans would quickly review your suggested option to...

Worth a try. How would we use it server-side?

Workaround: https://codesandbox.io/s/sandpack-project-forked-ln6xsm?file=/App.tsx

What is missing in toolbar buttons is resetting the current block type to the default type, which is trivial for flat blocks like headings but need some work for nested...

We're currently using [is-hotkey](https://github.com/ianstormtaylor/is-hotkey/blob/master/src/index.js). I plan to move to https://github.com/jaywcjlove/hotkeys

This is where it's used https://github.com/udecode/slate-plugins/blob/8c94295c0a0871d7934be692286b1a66db6ef372/packages/common/src/utils/getToggleMarkOnKeyDown.ts#L16 Maybe try is-hotkey on a sandbox?

OK for the new default. Added to #672

Thanks for the issue. This is kind of expected with the current design, but it's indeed not consistent and should be solved once we implement the menu button.

https://user-images.githubusercontent.com/19695832/134973390-05cbaf39-a013-4e1d-8da4-25f55e224dbd.mp4

Is this fixed in latest slate?