Laurent Monin
Laurent Monin
I think that's hard to avoid because of white-labeling (which was always an issue anyway), the match was made wider to handle those in https://github.com/murdos/musicbrainz-userscripts/commit/e2f318c128406341ecd323bd3a3e3d0a8a75f305 but it still required `album`...
We should separate the 2 cases: - Bandcamp: `^https:\/\/[^.]+\.bandcamp\.com(?:\/(?:(?:album|track))\/[^/]+|\/|\/music)$` It will match: ``` https://artist.bandcamp.com/ https://artist.bandcamp.com/music https://artist.bandcamp.com/album/xxx https://artist.bandcamp.com/track/xxx ``` - Custom domain: `^https:\/\/[^/]+\/(?:(?:(?:album|track))\/[^/]+|music)$` It will match: ``` https://artist.domain/music https://artist.domain/album/xxx https://artist.domain/track/xxx ```...
> I like this approach, but I think matching `https://artist.bandcamp.com` (without the slash at the end) is important enough, at least very important to me :) > > Otherwise it...
> My main concern with this PR is really the macOS code that tries to resolve a misencoded filename against the filesystem. This feels to me as it is working...