Laurent Monin

Results 74 comments of Laurent Monin

This approach doesn't let the user set the order of preference for cover art sources. I'm not sure the actual problem is the fact it's a "cover art provider". We...

You summed it up pretty well, I agree on all 4 cases. First, we need to define what are local cover art files, they may have a way to determine...

@RaysDev please do not rebase each time you make changes it makes those hard to follow, such big set of changes shouldn't be 1 commit. Thanks ;)

> I've completed the feedback items you provided @zas and commited. Thanks. Can you also address Codacy check? https://app.codacy.com/manual/MetaBrainz/picard/pullRequest?prid=5052949

> @zas what do you think? Well, we can introduce such feature at any time, and we wanted to get rid of `dateutil` dependency, so I would keep this PR...

@skelly37 https://github.com/skelly37/picard/pull/5 adds a bit more logging

> > @phw, @zas What's wrong [there](https://github.com/metabrainz/picard/runs/7680182896?check_suite_focus=true)? I don't understand... This was a temporary server issue (it was returning http 500) when trying to upload [SARIF](https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning) results from [CodeQL action](https://github.com/github/codeql-action)....

@skelly37 your last commit is titled "consider it ready", it wouldn't help one looking at commit history. In general, I think you should be more careful about your commit messages.Things...

> Why doesn't Picard use squash on merge? Usually we want to preserve dev history, it is better to have smaller commits, especially when it comes to use bisect to...

For example, https://github.com/metabrainz/picard/pull/2137/commits/e012e84d22d23dd6a093426d25500ed80f910959 should be 2 small commits: - one introducing `_init_remote_commands()` - one changing the loop in `get_album_pane_tracks()` Why? Because those are independent changes.