Darren Gibson

Results 92 comments of Darren Gibson

@satorg Agreed. That's why I wanted to list out all the methods that we had now, and open a discussion on how we can improve the current situation. These methods...

@smarter While Using contextual derivation might also reduce lines of code, it doesn't solve the other problems `Order1` solves.

Alot changed, I wish they had proper release notes... https://github.com/cquiroz/scala-java-time/compare/v2.3.0...v2.4.0?w=1

@armanbilge I see you updated in #2017, I'll close this then.

This does feel like the right move, but there are areas where performance of `JSON.parse` is better besides just numbers. For instance `StringOfAsciiCharsReading`, `StringOfEscapedCharsReading`, `ArrayOfUUIDsReading`, `ArrayOfEnumADTsReading` and `ArrayOfCharsReading` where `JSON.parse`...

@armanbilge I think its the right move for 0.15. I'll think about it for 0.14.x and talk with @zmccoy. I wish we had some benchmarks for nodejs as well to...

@Lasering I'm actually working on disabling that test for JS and adding JS to the CI. (See: https://github.com/circe/circe/pull/1905). I've approved for now, but it'll be worth merging main once more...

Thanks for the PR @cristiborta. To be honest, I'm not convinced creating this as the standard encoder is a good idea. There are multiple ways to specify a locale, and...