Darren Gibson
Darren Gibson
@ChetanBhasin your issue is `Ok` and `NotFound` return an `M[Result[...*]]`, so when you do `F.getProduct.map ...` you should really be using `flatMap` so you aren't doing `M[M[Result[...*]]`. Also, just random...
You'll need to add the `rho-swagger` and `rho-swagger-ui` artifacts as dependencies.
IMHO, 2/3 are better than 1. I prefer to avoid the monorepo if possible as it allows RHO to iterate somewhat quicker and more independently from Http4s.
@RafalSumislawski The `ServiceErrorHandler` can still be used with Rho, but it only triggers if there is an exception. In many places it isn't an exception, but some validation that fails....
So, I also started this a while back and unfortunately it fell on the back burner. Here was some of my work: https://github.com/http4s/rho/compare/master...zarthross:Swagger-Typeclasses I was taking the approach of having...
I agree that my approach was going to be at lossy. I was trying to have a minimal API change, and minimize some pain points, but perhaps something more drastic...
I suspect we should only be matching on the path and not on the query parameters, and letting the route fail if required parameters aren't provided. Unfortunately we can't (currently)...
@dvgica Sorry for the late review. The code itself looks fine, but we need to update with the latest from main, and fix the mima issues: ``` [error] genericExtras: Failed...
Unfortunately, I don't have any reason to think Mima is wrong here... your change is 100% source compatible, but the way Scala tends to organize things into jvm bytecode differs...
Yes we can! That is a big oversight! We'll get that fixed. Thanks!